Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mailing list start page #4422

Merged
merged 5 commits into from
Dec 11, 2024
Merged

Update mailing list start page #4422

merged 5 commits into from
Dec 11, 2024

Conversation

emmaachesongray
Copy link
Contributor

Trello card

https://trello.com/c/fJCrZY9u/7054-update-content-on-mailing-list-start-page

Context

Changes proposed in this pull request

Guidance to review

@github-actions github-actions bot added ruby Pull requests that update Ruby code test labels Dec 10, 2024
@github-actions GitHub Actions
Copy link

Review app deployed to https://get-into-teaching-app-review-4422.test.teacherservices.cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
12 New issues
10 Accepted issues

Measures
0 Security Hotspots
95.7% Coverage on New Code
0.3% Duplication on New Code

See analysis details on SonarQube Cloud

gemmadallmandfe
gemmadallmandfe approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Happy for this to be merged after a tech review

martyn-w
martyn-w approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@martyn-w martyn-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@emmaachesongray emmaachesongray merged commit 1a8a028 into master Dec 11, 2024
27 checks passed
@emmaachesongray emmaachesongray deleted the update-mailing-list-start-page branch December 11, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GayeCord GayeCord GayeCord left review comments

@gemmadallmandfe gemmadallmandfe gemmadallmandfe approved these changes

@martyn-w martyn-w martyn-w approved these changes

@Sarah-DfE Sarah-DfE Awaiting requested review from Sarah-DfE

Assignees
No one assigned
Labels
Review ruby Pull requests that update Ruby code test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emmaachesongray @martyn-w @gemmadallmandfe @GayeCord